Update logging.rst #12367
Merged
Update logging.rst #12367
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In XML a dash is used for the attribute max-files, but in the comment above that XML element an underscore was used (max_files). Other XML examples in the Symfony Docs (like the routing doc page) use dashes for XML attributes, so I concluded that this XML attribute is also correctly written, and the comment has to be changed instead.
|
@vmeijer super nice catch and perfectly explained! Thanks a lot for fixing this ... and congrats on your first Symfony Docs contribution! |
javiereguiluz
added a commit
that referenced
this pull request
Sep 25, 2019
This PR was merged into the 3.4 branch. Discussion ---------- Update logging.rst In the XML example of [Logging - How to Rotate your Log Files](https://symfony.com/doc/current/logging.html#how-to-rotate-your-log-files) a dash is used for the attribute `max-files`, but in the comment above the `monolog:handler` XML element an underscore was used (`max_files`). Other XML examples in the Symfony Docs (like the routing doc page) use dashes for XML attributes, so it looks like this XML attribute shares that style, and the comment could be changed instead. Commits ------- e9f12fc Fix typo for max-files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the XML example of Logging - How to Rotate your Log Files a dash is used for the attribute
max-files, but in the comment above themonolog:handlerXML element an underscore was used (max_files).Other XML examples in the Symfony Docs (like the routing doc page) use dashes for XML attributes, so it looks like this XML attribute shares that style, and the comment could be changed instead.